Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml dependencies need cleanup? #1995

Closed
laniakea64 opened this issue Apr 8, 2024 · 1 comment
Closed

Cargo.toml dependencies need cleanup? #1995

laniakea64 opened this issue Apr 8, 2024 · 1 comment

Comments

@laniakea64
Copy link
Contributor

During recent research for vim-just I ran across this - https://deps.rs/crate/just

Where couple things jumped out:

  1. just's dependency on regex states version 1.5.4, which the deps.rs link flags as a security vulnerability. However, just is actually using regex version 1.10.3 -

    just/Cargo.lock

    Lines 715 to 718 in c237c00

    [[package]]
    name = "regex"
    version = "1.10.3"
    source = "registry+https://github.com/rust-lang/crates.io-index"

    Should this be updated in Cargo.toml to prevent false positives?

  2. just declares a development dependency on yaml-rust, which is unmaintained. AFAICT this dependency is completely unused in today's just code, seems its use was removed in bb5b962 ?

neunenak added a commit to neunenak/just that referenced this issue Apr 10, 2024
cf. casey#1995 update regex and remove
yaml-rust
neunenak added a commit to neunenak/just that referenced this issue Apr 10, 2024
cf. casey#1995 update regex and remove
yaml-rust . Also update the heck dependency to its latest version.
@casey
Copy link
Owner

casey commented May 15, 2024

I think this was fixed in #1999.

@casey casey closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants