Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with getAllNamedRoles function using wrong index in managementEnforcer.ts #477

Closed
wants to merge 1 commit into from

Conversation

divyank-p
Copy link

@divyank-p divyank-p commented Apr 29, 2024

Fix: #476

Fix the issue in getAllNamedRoles function in managementEnforcer.ts where it is supposed to element from 0-index but is using 1-index

Screenshot 2024-04-28 at 4 18 12 PM

This PR fixes the issue in `getAllNamedRoles` function in `managementEnforcer.ts` where it is supposed to element from 0-index but is using 1-index
@casbin-bot
Copy link
Member

@nodece @Shivansh-yadav13 please review

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@divyank-p divyank-p changed the title fixed#476: issue with getAllNamedRoles function using wrong index fix: issue with getAllNamedRoles function using wrong index in managementEnforcer.ts Apr 29, 2024
@hsluoyz
Copy link
Member

hsluoyz commented Apr 29, 2024

@divyank-sc this PR is totally wrong. For p, alice, role-admin, the role is index-1, not index-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Discrepancy between getAllNamedRoles function implementation and comments
4 participants