-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tscfg-maven-plugin #28
Conversation
Hey @timvlaer thanks much for your interest and willingness to contribute! Sorry, I still have to look at this carefully but at first glance I'm wondering whether what's already published can provide the intended core functionality here; I'm referring to #24, in particular this #24 (comment) ? |
I think this is what intended in #21 (also in FAQ) but for Maven projects instead of SBT. |
Can you please indicate how to publish the plugin? This is not clear to me by looking at your pom or readme. Thx. |
I added the Sonatype oss repository in distributionManagement, so you should be able to deploy this plugin using the In the meantime I was also looking to extend the Travis CI build to include this project. However, this seems not straight-forward, since it's a completely separated project. So that started me thinking that we might create a new top-level github repo/project for this plugin. What do you think? Arguments for creating a new project:
Arguments for adding the plugin to this project:
|
Yes, the "separated project" quick reaction came to mind when I first looked at this PR. You are making good points. In general I'm happy to incorporate your plugin here as long as its testing, CI, and publishing are streamlined, ideally as part of the existing |
Ok, let's start with a separated project then and see how things evolve over time. I'll try to create the project in the coming days and let you know where to find it. It might be interesting to refer it in the readme of tscfg project, If you don't mind. |
No, I won't mind at all! and yes, do let me know when you have news about the new project. Thanks again! |
To keep you posted, I created a new project with everything in place. I still need to add the artefact to the Maven Central Repo. That will probably be something for next week. |
Added to the central repo: https://oss.sonatype.org/#nexus-search;quick~tscfg-maven-plugin |
Great, thanks much again for this. I just updated the readme to link to your plugin (under the running section). Please take a look and let me know if you would like any changes to the way I'm referencing your plugin. |
This looks good to me, thanks for adding it to the readme. |
This PR contains a maven plugin that generates Typesafe Config using the tscfg tool.
See README for usage details. Example:
When you run
mvn generate-sources
, the plugin will readapp.spec.conf
in the/config-spec
directory at the root of your Maven project. It will generate a Java 8 classbe.timvanlaer.service.config.ApplicationConfig
.