chore: make Carp compile w/ GHC 9.2 + stack lts20.0 #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to the hashable library require us to implement `Eq` for `Context` types, which I've defined as basic environment equality across the contexts. In addition, I had to eliminate a few cases of uni patterns that GHC did not catch before.
|
Wow, great fix, thank you so much! It seems like it worked on CI right? (The failing tests are because the clang version mismatch iirc?) |
Yeah, I think the nix and linux CIs are still failing because of an absent flag for their clang versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the hashable library require us to implement
EqforContexttypes, which I've defined as basic environment equality across the contexts. In addition, I had to eliminate a few cases of uni patterns that GHC did not catch before.#fixes #1448