Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cleanup core IO docs #1447

Merged
merged 2 commits into from
Dec 28, 2022
Merged

Conversation

scolsen
Copy link
Contributor

@scolsen scolsen commented Dec 20, 2022

This commit also makes some modifications to the source file to improve readability.

FIXES #1445

This commit also makes some modifications to the source file to improve
readability.

FIXES carp-lang#1445
@scolsen scolsen requested a review from a team December 23, 2022 18:08
Copy link
Collaborator

@eriksvedang eriksvedang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice!

(defn getenv [s]
(let [e (getenv- (String.cstr s))]
(if (null? e)
(Maybe.Nothing)
(Maybe.Just (from-cstr e)))))
)

; TODO: document this cool stuff, possibly even include an example!
; TODO(#1445): document this cool stuff, possibly even include an example!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this line can be removed now?

@eriksvedang eriksvedang merged commit 8c5845e into carp-lang:master Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document println*
2 participants