Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the memory management system further #1442

Merged
merged 2 commits into from
Dec 28, 2022
Merged

Document the memory management system further #1442

merged 2 commits into from
Dec 28, 2022

Conversation

scolsen
Copy link
Contributor

@scolsen scolsen commented Oct 31, 2022

Adds some details about the internals of the memory management system.

@scolsen
docs: add implementation detail to Memory.md
20d485e 
This commit begins the process of adding additional details on the
current implementation and operation of the memory management system.
Readers who are extra curious about how it works can read these sections
to gain an understanding.
@scolsen
docs: add further details on memory management
2e54118 
Describes memory states and reference analysis.
@scolsen scolsen requested a review from a team October 31, 2022 00:08
eriksvedang
eriksvedang approved these changes Nov 1, 2022
View reviewed changes
Copy link
Collaborator

@eriksvedang eriksvedang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice writeup! I'm a little unsure of putting this into docs given that I don't think it's the entirely correct way of doing it, see #1317 for some ideas for improvements. But it's probably a nice help for some people, we just need to try to keep it updated if things change.

Also, I'm very open to any other ideas for making the whole "algorithm" nicer.

@scolsen
Copy link
Contributor Author

scolsen commented Nov 1, 2022

Nice writeup! I'm a little unsure of putting this into docs given that I don't think it's the entirely correct way of doing it, see #1317 for some ideas for improvements. But it's probably a nice help for some people, we just need to try to keep it updated if things change.

Also, I'm very open to any other ideas for making the whole "algorithm" nicer.

That makes sense -- we could possibly put it in hacking.md instead so that it's clearer that it might be changed, but even then it's probably best to hold off on this until we've got an implementation that we feel is relatively stable.

@eriksvedang
Copy link
Collaborator

Yeah I didn't mean to discourage you though, it's a really nice explanation! And most of it should probably still hold true...

@eriksvedang eriksvedang merged commit 3397223 into carp-lang:master Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriksvedang eriksvedang eriksvedang approved these changes

@hellerve hellerve hellerve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scolsen @eriksvedang @hellerve