Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fixes scoop install as admin user #1399

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

TimDeve
Copy link
Contributor

@TimDeve TimDeve commented Mar 17, 2022

This fixes error in Windows pipelines by forcing the scoop installer to run.

I don't believe there is much point in not-running as Admin given the environment the CI runs in.

Edit: had to upgrade the Windows version because 2016 is getting deprecated but it comes with ASAN errors we've seen before.

@TimDeve TimDeve force-pushed the fix-scoop-admin-install branch 8 times, most recently from a76aca9 to be8033f Compare March 17, 2022 18:10
@eriksvedang
Copy link
Collaborator

Looks good, but the CI still fails on Windows?

@TimDeve
Copy link
Contributor Author

TimDeve commented Mar 18, 2022

Yes this is the error I mentioned in the edit, still trying to fix it. Annoyingly I can't reproduce locally which is why we stayed on 2016 until now.

@TimDeve TimDeve force-pushed the fix-scoop-admin-install branch 10 times, most recently from 8954aba to 4762343 Compare March 18, 2022 17:07
@eriksvedang
Copy link
Collaborator

@TimDeve Oh, sorry I read sloppily. Thanks for looking into it!

@TimDeve TimDeve force-pushed the fix-scoop-admin-install branch 5 times, most recently from 804c0b1 to f059022 Compare March 18, 2022 21:58
We're encountering the following error and I can't resolve it:
actions/runner-images#4978
@TimDeve
Copy link
Contributor Author

TimDeve commented Mar 19, 2022

So I've disabled sanitize-addresses because I can't find a solution to the problem, it seems to come from the clang that comes with these newer windows version but even using our scoop's clang it doesn't work.

I believe it needs a specific combination of flags (maybe even passing the asan libs directly if some of the issues I found are to be believed) but the fact I can't reproduce locally makes it quite hard to debug.

I would merge like this as I think it's more useful to have a partially working Windows CI than none at all, I will raise an issue to track the problem and try to make a minimal CI pipeline to reproduce the issue.

@eriksvedang eriksvedang merged commit 5535fd7 into carp-lang:master Mar 21, 2022
@eriksvedang
Copy link
Collaborator

@TimDeve Sounds good, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants