feat: add c-name meta field #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an implementation of Boxes, memory manged heap allocated values. Boxes are implemented as C pointers, with no additional structure but are treated as structs in Carp. To facilitate this, we need to add them as a clause to our special type emissions (TypesToC) as they'd otherwise be emitted like other struct types. Co-authored-by: Veit Heller <[email protected]>
Make sure we free the box!
This reverts commit 70ec6d4.
Now that a builtin type named Box exists, the definitions in this file cause a conflict. I've renamed the "Box" type in the functor example to remove the conflict.
Box.peek allows users to transform a reference to a box into a a reference to the box's contained value. The returned reference will have the same lifetime as the box. This function allows callers to manipulate the value in a box without re-allocation, for example: ```clojure (deftype Num [val Int]) (let-do [box (Box.init (Num.init 0))] (Num.set-val! (Box.peek &box) 1) @(Num.val (Box.peek &box))) ``` This commit also includes tests for Box.peek. Co-authored-by: TimDeve <[email protected]>
This commit adds a new special compiler meta key, c-name, that enables users to explicitly c the C identifier Carp should emit for a given symbol. For now, it is only explicitly supported for Def and Defn forms. For example: ```clojure (defn foo-bar [] 2) (c-name foo-bar "foo_bar") ``` Will cause foo-bar in emitted C code to be emitted as `foo_bar` instead of `foo_MINUS_bar`. I've also refactored some of the meta code to be a bit more principled about keys that are understood by the compiler.
Adds a section on using the c-name meta field to override identifiers exclusively defined in Carp. Also performs some minor editorial.
|
I'm not sure why the commit history here contains a bunch of old stuff. afaict the change set is correct. I can re-branch and cherrypick if we want to discard these old commits. |
eriksvedang
approved these changes
Mar 17, 2022
|
@scolsen I'll squash merge so I think it's fine to leave the history. Do you know if the Windows build failing is a real problem? |
Seems to be unrelated, I'll try to raise a PR for that separetely. |
hellerve
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new special compiler meta key, c-name, that enables
users to explicitly c the C identifier Carp should emit for a given
symbol. For now, it is only explicitly supported for Def and Defn forms.
For example:
Will cause foo-bar in emitted C code to be emitted as
foo_barinsteadof
foo_MINUS_bar.I've also refactored some of the meta code to be a bit more principled
about keys that are understood by the compiler.
fixes #1389