Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1347 by ignoring generically typed symbols on printing C #1373

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

hellerve
Copy link
Member

@hellerve hellerve commented Jan 7, 2022

This PR fixes #1347 by ignoring generically typed symbols when we echo C output. That should usually be safe, since the specializations will still be printed when the forms require them.

Cheers

@hellerve hellerve requested a review from a team January 7, 2022 16:45
Copy link
Contributor

@scolsen scolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Collaborator

@eriksvedang eriksvedang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@eriksvedang eriksvedang merged commit 027d8b3 into carp-lang:master Jan 10, 2022
@hellerve hellerve deleted the veit/fix-1347 branch January 10, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

carp: Can't emit symbol of generic type: e : a at line 4, column 3 in
3 participants