Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes nix install by using correct pkg-configDepends config key #1372

Merged
merged 2 commits into from
Jan 9, 2022

Conversation

TimDeve
Copy link
Contributor

@TimDeve TimDeve commented Jan 7, 2022

As reported by Hrafn Blóðbók, nix updated references to pkgconfig in its codebase to use the pkg-config spelling, this seems to break the installation of Carp using nix.

See this PR: NixOS/nixpkgs@9bb3fcc

The current error when installing:

error: anonymous function at /nix/var/nix/profiles/per-user/root/channels/nixos/pkgs/development/haskell-modules/generic-builder.nix:13:1 called with unexpected argument 'pkgconfigDepends'

       at /nix/var/nix/profiles/per-user/root/channels/nixos/lib/customisation.nix:69:16:

           68|     let
           69|       result = f origArgs;
             |                ^
           70|

We might need to update the nix action as well, just pushing it like this for now.

As reported by Hrafn Blóðbók, nix updated references to pkgconfig in its
codebase to use the `pkg-config` spelling, this seems to break the
installation of Carp using nix.

See this PR: NixOS/nixpkgs@9bb3fcc
@TimDeve
Copy link
Contributor Author

TimDeve commented Jan 7, 2022

Updated the Github Actions so it uses 21.05, guess it means this is now the minimum Nix version to install Carp with, hope that doesn't break anyone's workflows.

@eriksvedang eriksvedang merged commit 330dc52 into carp-lang:master Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants