Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure registered types with fields emit path #1364

Merged
merged 1 commit into from
Dec 16, 2021
Merged

fix: ensure registered types with fields emit path #1364

merged 1 commit into from
Dec 16, 2021

Commits on Dec 12, 2021

  1. fix: ensure registered types with fields emit path 

    This fixes an issue where by types with fields registered in modules
weren't emitted with their module paths. This makes the behavior between
RegisterTypeWithoutFields and RegisterTypeWithFields the same. They both
account for the current module path in which the type is registered and
output the emitted typedef appropriately.

This fix also eliminates the need for a workaround in core/Pattern.carp.
We previously had to register MatchResult with an override because of
the old behavior, but now the override is no longer needed (since
MatchResult is defined as PatternMatchResult in its source header).  The
call (register MatchResult) within (defmodule Pattern) emits
"PatternMatchResult" by default since we now account for module paths
for registered types.
    @scolsen
    scolsen committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    366a28a View commit details
    Browse the repository at this point in the history