Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect line number in repl #1282

Merged
merged 3 commits into from
Jul 23, 2021
Merged

fix: respect line number in repl #1282

merged 3 commits into from
Jul 23, 2021

Conversation

hellerve
Copy link
Member

This PR fixes the behavior of the REPL to respect line numbers.

Example:

> (def x 1)
> :i x
x : Int
  Defined at line 1, column 2 in 'REPL'
> (def x 2)
> :i x
x : Int
  Defined at line 3, column 2 in 'REPL' ; <= this used to say line 1 before!

Cheers

@hellerve hellerve requested a review from a team July 22, 2021 16:33
@eriksvedang eriksvedang merged commit cbdf425 into carp-lang:master Jul 23, 2021
@eriksvedang
Copy link
Collaborator

Oh, really nice catch! And a great fix!

@hellerve hellerve deleted the veit/line-no-repl branch July 24, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scolsen scolsen scolsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hellerve @eriksvedang @scolsen