fix: handle unhandled case in isCaptured #1068
Conversation
Previously, this function missed a case, namely, one where the head of a type definition contains a concrete struct, like `Maybe` with a variable argument, `a`. That is, ``` (deftype (Foo (Maybe a)) [x (Maybe a)]) ``` Would throw a type error. This commit fixes that issue.
|
Before we merge this, it's not clear to me that we should even allow type heads such as In such a case, isn't it likely the author meant |
|
Yeah, I don't see what |
sounds good! I think we should keep this case for exhaustiveness reasons, but let me add an additional check for type heads that ensures all their types are variables. |
|
@scolsen That was merged too early, no? |
Yeah, it's ok though, I can push the other changes as a separate PR |
Previously, this function missed a case, namely, one where the head of a
type definition contains a concrete struct, like
Maybewith a variableargument,
a. That is,Would throw a type error. This commit fixes that issue.