Use different command types for each arity #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should get rid of the ugly errors introduced to address incomplete patterns in the Be careful, there're some bits I'm not sure about. I'll start a review to ask about them. |
jacereda
commented
Dec 10, 2020
| Right (XObj (Lst [XObj (Command (NullaryCommandFunction nullary)) _ _, _, _]) _ _) -> | ||
| nullary ctx'' | ||
| Right (XObj (Lst [XObj (Command (UnaryCommandFunction unary)) _ _, _, _]) _ _) -> | ||
| case expandedArgs of |
There was a problem hiding this comment.
Should these use args or expandedArgs?
There was a problem hiding this comment.
Not sure, do you think it ever matters? I'll merge as is, seems fine...
|
Primitives could follow a similar approach. |
hellerve
reviewed
Dec 11, 2020
hellerve
approved these changes
Dec 11, 2020
eriksvedang
approved these changes
Dec 13, 2020
| Right (XObj (Lst [XObj (Command (NullaryCommandFunction nullary)) _ _, _, _]) _ _) -> | ||
| nullary ctx'' | ||
| Right (XObj (Lst [XObj (Command (UnaryCommandFunction unary)) _ _, _, _]) _ _) -> | ||
| case expandedArgs of |
There was a problem hiding this comment.
Not sure, do you think it ever matters? I'll merge as is, seems fine...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.