Commands don’t save meta information

[hellerve]

As discussed in #542, it seems as if commands do not save their meta information. The behavior exhibited seems similar to when documenting modules was impossible.

Cheers

[eriksvedang]

This works now? @hellerve

[hellerve]

It doesn’t seem to:

> (info Dynamic.String.concat)
concat : Dynamic
Defined at line 0, column 0 in 'dummy-file'
> (doc Dynamic.String.concat "concats a string dynamically")
> (info Dynamic.String.concat)
concat : Dynamic
Defined at line 0, column 0 in 'dummy-file'

[eriksvedang]

Huh, it works for me on bit-width:

鲤 :i bit-width 
bit-width : Dynamic Defined at line 0, column 0 in 'dummy-file'
鲤 (doc bit-width "stuff")
鲤 :i bit-width
bit-width : a
Defined at line 0, column 0 in 'dummy-file'
Documentation: stuff

So maybe it's something with commands inside modules.

[hellerve]

Maybe, but also the type changed in your example (from Dynamic toa), which leads me to believe that that’s a doc stub we’re seeing.

[hellerve]

But it does look like this works as of current master, insofar as docstubs are created correctly.

[eriksvedang]

Oh, right... totally missed that! Needs more investigation then, hopefully it's not that hard to fix since it works for other kinds of definitions.

[eriksvedang]

I think this should be fixed in master now..!

[eriksvedang]

For posterity, the bug was caused by two things:

1. The commands that were added to the starting env had their Path XObj:s set to SymPath [] name, they are now qualified like this SymPath ["Dynamic"] name
2. When looking up symbols in primitiveMetaSet, we need to do an additional attempt where Dynamic is prepended to the path or else you won't find the symbol, in which case a stub will be created instead.

[hellerve]

Oh, fun! Thanks for the explanation :)