Set default value of filterset data to MultiValueDict

[sgordon16]

fix for issue #1633

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af9f13b) 98.59% compared to head (97ec657) 98.59%.
Report is 1 commits behind head on main.

❗ Current head 97ec657 differs from pull request most recent head 390c0f2. Consider uploading reports for the commit 390c0f2 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1634   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files          15       15           
  Lines        1283     1284    +1     
=======================================
+ Hits         1265     1266    +1     
  Misses         18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[carltongibson]

Hi @sgordon16 — just to let you know, I'm not ignoring this.

I think it looks great. (I can't think of any issues, unless folks are doing weird isinstance checks...)

I'm slowly edging towards a release, and this will be part of that.

[carltongibson]

If you had capacity though, adding a test that demonstrates the change in behaviour would be handy. Thanks.

[sgordon16]

If you had capacity though, adding a test that demonstrates the change in behaviour would be handy. Thanks.

Done

[sgordon16]

I also just want to point out that this is what Django does in the BaseForm class here.

[carltongibson]

@sgordon16 Yes, it's certainly correct. I would have merged it already, but I want to play with a couple of things in the shell, and just haven't had time for that yet.

🎁

[carltongibson]

OK, brilliant. Let's have it. Thanks @sgordon16 🎁