Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0010 | Add 10297 label for fida.finance #906

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ssledz
Copy link

@ssledz ssledz commented Sep 9, 2024

No description provided.

@rphair rphair added the CIP-0010: new registry entry Adding a new entry to the metadata label registry label Sep 9, 2024
@rphair rphair changed the title Add 10297 metadat label to CIP-0010/registry.json CIP-0010 | Add 10297 label for fida.finance Sep 9, 2024
@rphair
Copy link
Collaborator

rphair commented Sep 9, 2024

@ssledz - Would you please edit your submission so the metadata number is sorted in correct numerical order with the other submissions and correct the mismatch in indentation?

@Ryun1 @Crypto2099 @perturbing certainly this looks justified: https://medium.com/@fida.finance/democratizing-the-insurance-industry-through-blockchain-990700fd438f

... but maybe we should wait to ensure the request is properly formatted before enabling the new GitHub CI processing of CIP-0010 additions. I'm not sure if it checks for proper numerical order and/or sorts them (cc @Godspeed-exe from #837).

@Godspeed-exe
Copy link
Contributor

@rphair my workflow does not check for sorting / do sorting.

@perturbing
Copy link
Contributor

@rphair, my view of this CIP is that currently any project can claim a label number. So with that, I think this PR indeed looks justified by your above link.

That said, I do wonder how this will pan out in the future, as there is no clear guideline. Furthermore, currently labels are forever, are all registered labels still actively used? These two things might cause some issues in the future, where we as CIP editors do not have clear guidance.

@rphair
Copy link
Collaborator

rphair commented Sep 10, 2024

Yes @perturbing - I agree on all of that & think that CIP-0010 might benefit from an update with whatever clarification might be necessary as project tag requests start coming in again.

One more issue is the human factor that, because of their sorted arrangement, these aren't just cardinal numbers as the CIP indicates but are also perceived as ordinal numbers. This has the interesting consequence that those apparently taking advantage of that ordinality will also be the least likely to acknowledge it:

... so perhaps this dialogue could also be considered in a CIP-0010 update that provides guidelines to establish project significance in numbering, as well as proof of legitimacy.

@ssledz this is just a side discussion to your submission & rest assured we will enable the GitHub CI workflow on this PR as soon as you clean up your edited file as requested.

@perturbing
Copy link
Contributor

perturbing commented Sep 10, 2024

Just a little brainstorm :)

  1. I think one addition to CIP-010 could be the addition of the test that there is a reasonable chance that others (people/tooling etc) observing this metadata might want clarity. For example, any project that has an app where users connect their wallet, the wallets might want to leverage the knowledge of this CIP. But applications that are isolated (for whatever reason), do not (liquidation on a lending protocol for example).

2). We could hash (even with a VRF if needed for proper randomness), their PR, and modulo reduce it to fit in the range and have that as their number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIP-0010: new registry entry Adding a new entry to the metadata label registry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants