Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPS-???? | Coin Selection Including Native Tokens #609

Closed
wants to merge 5 commits into from
Closed

CPS-???? | Coin Selection Including Native Tokens #609

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d13936b
building the draft of CPS
HinsonSIDAN Oct 20, 2023
26ec8a8
Adding some open questions
HinsonSIDAN Oct 20, 2023
1ec65ff
expand upon serlib points
twwu123 Oct 20, 2023
de942a8
Amending category to wallet
HinsonSIDAN Oct 20, 2023
d7c3f2a
Merge branch 'master' of https://github.com/sidan-lab/CIPs
HinsonSIDAN Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Amending category to wallet
  • Loading branch information
@HinsonSIDAN
HinsonSIDAN committed Oct 20, 2023
commit de942a846cb838fc374839358058569adb07a059
2 changes: 1 addition & 1 deletion CPS-0002/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
CPS: 2
Copy link
Collaborator

@rphair rphair Oct 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CPS: 2
CPS: ?

Please @SIDANWhatever you will also need to rename the containing directory from CPS-0002 to something non-numerical (like CPS-XXXX or CPS-token-selection.

Title: Coin Selection Approach for Post Native Tokens Era in Cardano
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Title: Coin Selection Approach for Post Native Tokens Era in Cardano
Title: Coin Selection Including Native Tokens

If author & editors are in agreement that this is more specific and less redundant ("era", "Cardano") then let's please change the document title to the current PR title.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s. also @SIDANWhatever for fixing little things like this we recommend that your PR branch be set to "Allow edits by maintainers" (the general default when submitting a PR, and helpful to keep track of who recommended the changes behind each commit).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s. also @SIDANWhatever for fixing little things like this we recommend that your PR branch be set to "Allow edits by maintainers" (the general default when submitting a PR, and helpful to keep track of who recommended the changes behind each commit).

Seems its only work for PR from feature branch, should I close this PR and create a new one?

Copy link
Collaborator

@rphair rphair Oct 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to create a new PR... you should be able to extend the permissions by following these instructions (i.e. when you view this PR's branch in the repository which pushed it, with write permission in that repository) 🤓 https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests

Status: Open
Category: Plutus
Category: Wallets
Authors:
- Hinson Wong <[email protected]>
- Tsz Wai Wu <[email protected]>
Expand Down