Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0025 | Change "NFT" to "token" #593

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

BrockCruess
Copy link
Contributor

As we have standardized the use of fungible tokens for media/collectible tokens (ie: art editions & book copies), we need to avoid using "NFT" as a blanket term in CIP documentation as it can create confusion around whether a CIP includes these other token variants.

As we have standardized the use of fungible tokens for media/collectible tokens (ie: art editions & book copies), we need to avoid using "NFT" as a blanket term in CIP documentation as it can create confusion around whether a CIP includes these other token variants.
@rphair rphair changed the title Change "NFT" to "token", avoiding exclusion of FT and RFT media tokens CIP-0025 | Change "NFT" to "token" Sep 16, 2023
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrockCruess I'm trimming the title by removing avoiding exclusion of FT and RFT media tokens because there could well be additional reasons for doing this. I'm putting it on the agenda for the next CIP editors' meeting so we can start thinking about any broader significance of this change beyond simply including semi-fungible tokens.

My "Devil's Advocate" argument for not changing CIP-0025 would be that tokens with some fungibility would be covered more currently by CIP-0068, while on the other hand pure applications of CIP-0025 were more specifically conceived for NFTs and therefore the NFT term serves a historical purpose by justifying the design decisions that were documented at the time.

@BrockCruess
Copy link
Contributor Author

@rphair fair point on the title. However I'd personally prefer we maintain separation of CIP-0068 and CIP-0025, and I know I'm not alone on that. A lot of people already use CIP-0025 for RFTs and a whole art platform is now built and thriving on it (528 artists, 31092 works). There's realistically no downside to the inclusion, and cementing something historically - for the sake of history alone - just leads to bloat in standards. We'd have to copy and paste CIP-0025 and just add RFTs to the new CIP.

Looking forward to the outcome of the meeting's discussion!

@Crypto2099
Copy link
Collaborator

For what it's worth, I do not believe that this is a "breaking change" and is how many "support" platforms have operated already (i.e. treat every token w/ 721 data the same regardless of the quantity on chain).

So, I don't feel there are any major hurdles to making this relatively minor change to the wording of CIP-25 as it will not break any existing solutions that I am aware of. However, that said, there are some other facets of support for "Rich Fungible Tokens" (RFTs for the purpose of CIP-25 & CIP-68) that may warrant their own, separate CIP in the future to help explorers and marketplaces navigate and smoothly handle these tokens.

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sounds good all around. I do feel better about having the updated term there which correctly indicates the range of contemporary use and don't think it dulls the historical significance to change it. 😇

Copy link
Collaborator

@Crypto2099 Crypto2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are minor and largely cosmetic but serve to represent and open up this metadata standard for more than strictly tokens with a quantity = 1. I see no reasons or means by which this would cause any errors with existing implementations so believe it is ready to be merged in.

@rphair
Copy link
Collaborator

rphair commented Sep 21, 2023

As per our last meeting agreement, not merging yet pending any dispute from implementors (@SmaugPool @alessandrokonrad @mmahut ... feel free to include others) in case the wording change goes against their ongoing intent in any way. Otherwise we'll leave it Last Check to merge at next CIP meeting: https://hackmd.io/@cip-editors/74

@rphair rphair added the State: Last Check Review favourable with disputes resolved; staged for merging. label Sep 21, 2023
@SmaugPool
Copy link
Contributor

These changes are minor and largely cosmetic but serve to represent and open up this metadata standard for more than strictly tokens with a quantity = 1. I see no reasons or means by which this would cause any errors with existing implementations so believe it is ready to be merged in.

I agree with @Crypto2099.

@rphair rphair merged commit 0e96f20 into cardano-foundation:master Oct 3, 2023
Ryun1 pushed a commit to Ryun1/CIPs that referenced this pull request Nov 17, 2023
* Change "NFT" to "token", avoiding exclusion of FT and RFT media tokens

As we have standardized the use of fungible tokens for media/collectible tokens (ie: art editions & book copies), we need to avoid using "NFT" as a blanket term in CIP documentation as it can create confusion around whether a CIP includes these other token variants.

* change CIP title also in top level README

* also change CIP name in token metadata registry

---------

Co-authored-by: Robert Phair <[email protected]>
@rphair rphair removed the State: Last Check Review favourable with disputes resolved; staged for merging. label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants