-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0048? | NFT metadata references and payloads #249
Closed
Closed
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
05f7c34
Introducing CIP-0048? Extended 721 metadata
Jack-0 01bce73
added forum post
Jack-0 a2fe0d4
amendments to specification reserved keywords
Jack-0 c476add
added pseudo code usage example
Jack-0 3d1b4f4
added external keyword
Jack-0 c41d545
added external char shortcut
Jack-0 56bcda6
added comment on references
Jack-0 07d87d1
proof read changes
Jack-0 c1988c3
updated CIP-0048.md
Jack-0 91ce437
updated CIP-0048.md to include fallback option
Jack-0 2706144
updated CIP-0048.md to include note on duplication
Jack-0 921e8eb
added a comment on references
Jack-0 fe506e1
updated CIP-0048.md to use policy and txhash
Jack-0 d8d5a30
updated CIP-0048.md grammar
Jack-0 2e7420a
Merge branch 'cardano-foundation:master' into master
Jack-0 827ca7b
refactored CIP48 into two CIPs
450812c
updated example
fc06058
CIP48 and CIP49 are seperate CIPs
6c9bada
reimplemented CIP48 -_-
2465815
updated CIP48
594400b
renamed CIP-0048/CIP-0048.md -> CIP-0048/README.md
aec50fc
updated README.md header
09b3b10
ammendments
54b0c63
ammendments
bc0906a
amendments
dc16d71
amendments to example
b7c36ac
merge
e4a6509
amendments
2364e8a
amendments
edf147b
amendments
4911949
amendments
b99a0aa
example update
c0d2aee
updates to handle image tag usage in CIP25
7bf0859
updates to handle files tag usage in CIP25
11eedf3
removed files in CIP48
404279a
behavior duplicated files in CIP25 if multiple refs are defined
7480cce
noticed txhashes should be an array
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
added external char shortcut
- Loading branch information
commit c41d5457a80364fe7e5b62688542de9b9f47fd77
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -35,7 +35,7 @@ Specifically, this proposal aims to solve for the following: | |||||
|version| this is described in 721 | not sure if it should be version 1.1? instead of 2| | ||||||
|data| contains the data type MIME | for example if base 64, data:"text/plain;base64"| | ||||||
|src|contains a list of poitners to payloads | ```"src":[0,1]``` or ``` "src":["payload0","payload1"]```| | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|external | used withing references to references another policy | ```'r':{"data:"text/plain","src":{[0,1]},"external":"<POLICY_ID>}"```| | ||||||
|external, e | used withing references to references another policy | ```'r':{"data:"text/plain","src":{[0,1]},"external":"<POLICY_ID>}"```| | ||||||
|
||||||
|
||||||
*Please note I offer optional single char names to allow futher reduction in metadata size if desired* | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is an optional extension of the standard, it wouldn't make sense to use the same versioning scheme as CIP-0025 because there might be other proposed extensions which either conflict or are simply used in total separation from this one. Say we have two mutually exclusive extensions for CIP-0025 with versions
2.1
and2.2
. Now, shouldn't2.2
implies that2.1
is also used? What if, no, people just want to use2.1
?I think CIP-0025 lacks extensibility mechanisms; something that can let new extensions be specified in an additive manner (e.g. an extra field
extensions: ['CIP-0048']
).