Cleanup the new dependencies and our tooling setup. #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't fully configure the new dependencies correctly or fully get them working with our tooling rigging for compilation databases. - I needed to fix the sha256 of the benchmark. I pasted the wrong one, but didn't test it effectively. - Didn't successfully enable the use of Abseil from GoogleTest (including nice things like its symbolization, etc). Doing this is a bit awkward as it needs to go into our `.bazelrc`, but it works. - Didn't add libraries other that GoogleTest to the compile flags. - Didn't teach the compilation database creation step to cause these external repositories to be linked in and populated nicely. All of these are fixed. As I was making changes to the Python script here, I've added a test to at least type check it and fixed the type errors reported.
jonmeow
approved these changes
Nov 4, 2021
chandlerc
added a commit
that referenced
this pull request
Jun 28, 2022
I didn't fully configure the new dependencies correctly or fully get them working with our tooling rigging for compilation databases. - I needed to fix the sha256 of the benchmark. I pasted the wrong one, but didn't test it effectively. - Didn't successfully enable the use of Abseil from GoogleTest (including nice things like its symbolization, etc). Doing this is a bit awkward as it needs to go into our `.bazelrc`, but it works. - Didn't add libraries other that GoogleTest to the compile flags. - Didn't teach the compilation database creation step to cause these external repositories to be linked in and populated nicely. All of these are fixed. As I was making changes to the Python script here, I've added a test to at least type check it and fixed the type errors reported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't fully configure the new dependencies correctly or fully get
them working with our tooling rigging for compilation databases.
I needed to fix the sha256 of the benchmark. I pasted the wrong
one, but didn't test it effectively.
Didn't successfully enable the use of Abseil from GoogleTest
(including nice things like its symbolization, etc). Doing this is
a bit awkward as it needs to go into our
.bazelrc, but it works.Didn't add libraries other that GoogleTest to the compile flags.
Didn't teach the compilation database creation step to cause these
external repositories to be linked in and populated nicely.
All of these are fixed. As I was making changes to the Python script
here, I've added a test to at least type check it and fixed the type
errors reported.