Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Criteria for Carbon to go public #63

Merged
merged 22 commits into from
Nov 17, 2020

Conversation

brycelelbach
Copy link
Contributor

@brycelelbach brycelelbach commented Jun 10, 2020

@brycelelbach
Copy link
Contributor Author

I can't seem to add labels. @chandlerc mentioned that's probably a permissions issue and I should remind him on a telecon.

It is important for us to distinguish between minor leaks which do not warrant
going public and major leaks which do.

### Minor Leak
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyedit: "Minor Leaks"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, with rewrite of file


Minor leaks should not force us to prematurely go public.

### Major Leak
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyedit: "Minor Leaks"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, with rewrite of file

@@ -0,0 +1,232 @@
# Criterion for Carbon to go Public
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's late so I inverted "criteria" (the plural) with "criterion" (the singular) throughout this entire document.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, with rewrite of file

Additionally, there are costs associated with going public.
Greater participation brings great administrative and logistical overheads.

We propose that we should only go public when:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it an "all of" or "any of"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, with rewrite of file

We must make every effort to not create a hostile relationship between the Carbon
and C++ community.
One step that we take to avoid that is to ensure that we clearly acknowledge and
thank the C++ community and language designers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
thank the C++ community and language designers
thank the C++ community and language designers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, with rewrite of file

### Criteria: Ready to Make Long Term Investments

The community will not distinguish between a plan and promise.
The community will not distinguish between a exploration and a long term
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The community will not distinguish between a exploration and a long term
The community will not distinguish between an exploration and a long term

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, with rewrite of file

@jonmeow jonmeow added proposal A proposal WIP labels Jun 16, 2020
@chandlerc chandlerc changed the base branch from master to trunk July 2, 2020 03:21
@jonmeow
Copy link
Contributor

jonmeow commented Sep 23, 2020

@brycelelbach Were you going to continue with this proposal? Would you like help getting it ready for core team review?

@brycelelbach
Copy link
Contributor Author

Yah; that would be good. I've been a bit busy the last few weeks with my day job.

@jonmeow
Copy link
Contributor

jonmeow commented Sep 23, 2020

I've done a pass on this at:
https://docs.google.com/document/d/1Uir4sc1HuT5pOzRrFDnbuClzSYBEwE2Unbabr28e8iw/edit#

@chandlerc It may also help to have you in particular look at this and wording.

@brycelelbach brycelelbach requested a review from a team October 8, 2020 20:37
@google-cla google-cla bot added the cla: yes PR meets CLA requirements according to bot. label Oct 8, 2020
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to decide the best way to handle updating to the PR, and I thought I'd try this approach of pushing changes to the branch. @brycelelbach please let me know if you have concerns about me proceeding this way.

Additionally, there are costs associated with going public.
Greater participation brings great administrative and logistical overheads.

We propose that we should only go public when:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, with rewrite of file

@@ -0,0 +1,232 @@
# Criterion for Carbon to go Public
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, with rewrite of file

We must make every effort to not create a hostile relationship between the Carbon
and C++ community.
One step that we take to avoid that is to ensure that we clearly acknowledge and
thank the C++ community and language designers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, with rewrite of file


Minor leaks should not force us to prematurely go public.

### Major Leak
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, with rewrite of file

It is important for us to distinguish between minor leaks which do not warrant
going public and major leaks which do.

### Minor Leak
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, with rewrite of file

### Criteria: Ready to Make Long Term Investments

The community will not distinguish between a plan and promise.
The community will not distinguish between a exploration and a long term
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, with rewrite of file

@jonmeow jonmeow changed the title Criterion for Carbon to go public Criteria for Carbon to go public Oct 8, 2020
@jonmeow jonmeow added proposal rfc Proposal with request-for-comment sent out and removed WIP labels Oct 8, 2020
@brycelelbach
Copy link
Contributor Author

Sounds good to me

@sidney13 sidney13 added needs decision and removed proposal rfc Proposal with request-for-comment sent out comment deadline labels Oct 22, 2020
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally posting these, sorry for the last hour.

I'm generally happy with the approach being taken and the structure. But I think the wording and some of the details still needs work. In some cases, we can potentially just defer details for follow-ups, but in others may need to get the wording right on this iteration.

Comment on lines 108 to 118
Once Carbon goes public, it will be infeasible to guarantee that everyone
understands Carbon to be an idea for an experiment, rather than a promise with a
long-term commitment. If we end up abandoning the Carbon experiment, some users
will inevitably view the experience in a highly negative manner. Even with a
private community, we must consider the balance of where the experiment needs
long-term commitments to continue advancing.

Carbon should only go public when the core team is fully confident that there
are sufficient community members ready to make a long-term commitment to Carbon.
To gain such confidence, community members will need evidence for themselves and
their organizations that Carbon delivers on its goals.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section feels too strongly worded to me, and seems in contradiction with other points....

How can we have folks with a long-term commitment to Carbon when we still need broader field experience?

I would focus on the cost and difficulty of communicating about it being an experiment, rather than in terms of absolutes...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrasing and merging sections.

Comment on lines 120 to 139
### Long-term commitments from multiple organizations and individuals

We have a desire to make Carbon a collaboration of multiple organizations and
individuals to ensure the longevity and broad applicability of Carbon. However,
Carbon initially began as a project within a single organization. Thus, we can
expect that in Carbon's infancy the vast majority of contributions will come
from the initial contributing organization.

When Carbon goes public, we do not want it to be perceived as an initiative of a
single organization. Therefore, we should consider the diversity of
participation and the number of organizations willing to make long-term
commitments in Carbon before going public.

Some individuals must be ready to contribute to Carbon's design and
implementation, but that's not the only kind of long-term commitment that we
need. Adoption of Carbon also offers a way to build crucial field experience and
generate feedback.

If the diversity is insufficient, then we will work to increase it by inviting
additional parties to participate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section somewhat overstates the current situation.

I would suggest simplifying it to just talk about the necessity for committed interest from multiple individuals and organizations.

I'd also focus more on committed interest than the duration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear what you mean by this. Maybe you mean to delete the paragraph about needing both design/implementation and field experience intent? I've done that.

Similarly, I'm guessing by "duration" you mean the phrase "long-term". That's been removed as part of the larger switch to just "intent".


### Demonstration of potential

Carbon should only go public once it can be proven that it can deliver on its
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't say "proven"?

It also reads like it has to be all of them which seems infeasible. The rest of the section actually reads great, so I think it is just this sentence.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 172 to 174

We don't expect to offer training courses at this point, as the Carbon prototype
is still expected to be relatively immature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just skip this...

Suggested change
We don't expect to offer training courses at this point, as the Carbon prototype
is still expected to be relatively immature.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KateGregory requested training courses be addressed, on the doc. Is it problematic to keep? Is there a rephrasing that you'd be okay with?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On further thought, I've added a risk of "Over-evangelizing" and I'm moving the example there.

Comment on lines 187 to 196
### Launch event

We should have a compelling launch event when we go public. We should be ready
with:

- Technical talks from multiple speakers and organizations. This could be at a
conference or in our own remote or physical event.
- A website.
- A social media game plan.
- Tech press lined up.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wolffg here as he and I have chatted a bit about this as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've talked with him a bit about this. I've rephrased slightly ("We should be ready with" to "For example") but I think the real answer here is we'll need to plan for go-public separately from this doc.

Comment on lines 210 to 221
It is possible that Carbon will be perceived as a competitor to C++. Some may
view Carbon as an indictment of C++ and those who have dedicated their career to
developing C++. Those who work on Carbon, especially those who also currently or
previously work on C++, may be perceived in a negative light by the C++
community.

We must make every effort to not create a hostile relationship between the
Carbon and C++ communities. One step that we will take to avoid that is to
ensure that launch announcements clearly acknowledge and thank the C++ community
and language designers. After all, much of the experience that is driving the
creation of Carbon comes from C++ and an appreciation of its advantages over
other programming languages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree with the intent here, I think the wording of this section runs the risk of exacerbating the problem it describes.

I wouldn't go into as much detail about all of the things and/or ways this could go wrong, and I would focus more on what we should do rather than what we shouldn't.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 225 to 227
Carbon may be perceived as being owned and pushed by a single organization. This
may lead to a variety of different claims of nefarious intent in the development
of Carbon.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the above, rather than speculate on how bad it may be, I would re-focus this on the positive reasons we want to avoid this. The second paragraph I think does a good job of focusing on the positive things we will do.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 269 to 277
For example:

- A tech press site learns about Carbon and decides to publish a news article
about it.
- If a reporter has rumors, email leaks, or documentation leaks, community
members should not offer comments. We want to avoid having comments
accidentally substantiate rumors and result in an article.
- Someone aware of Carbon discloses information about it on social media and
draws substantial attention.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to above, I'd reduce the speculation about what might go wrong.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more wording tweaks from a quick online review with Jon and others.

Comment on lines 105 to 112
### Declared intent to use Carbon from multiple organizations and individuals

We should ensure there is at least an _intent_ to continue with Carbon, even if
circumstances later shift. This intent should come from multiple organizations
and individuals. It's important that Carbon be a collaboration in order to
ensure its longevity and broad applicability. Even if most of Carbon's early
contributions come from one organization, it's still crucial that others have
sufficient interest to contribute to its ecosystem.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Declared intent to use Carbon from multiple organizations and individuals
We should ensure there is at least an _intent_ to continue with Carbon, even if
circumstances later shift. This intent should come from multiple organizations
and individuals. It's important that Carbon be a collaboration in order to
ensure its longevity and broad applicability. Even if most of Carbon's early
contributions come from one organization, it's still crucial that others have
sufficient interest to contribute to its ecosystem.
### Sustained interest to use Carbon from multiple organizations and individuals
We should ensure there is at least an _sustained interest_ to continue with Carbon, even if
circumstances later shift. This interest should come from multiple organizations
and individuals. It's important that Carbon be a collaboration in order to
ensure its longevity and broad applicability. Even if most of Carbon's early
contributions come from one organization, it's still crucial that others have
sufficient interest to contribute to its ecosystem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did pretty much this same edit while we were talking. :)

docs/project/going_public.md Outdated Show resolved Hide resolved
Comment on lines 190 to 194
Carbon may be perceived as being owned and pushed by a single organization. We
must take steps during the development of Carbon to ensure that multiple
organizations are involved. We will ensure that launch announcements clearly
acknowledge and thank the individuals and organizations which have been involved
during its private development.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Carbon may be perceived as being owned and pushed by a single organization. We
must take steps during the development of Carbon to ensure that multiple
organizations are involved. We will ensure that launch announcements clearly
acknowledge and thank the individuals and organizations which have been involved
during its private development.
We
must take steps during the development of Carbon to ensure that multiple
organizations are involved. We will ensure that launch announcements clearly
acknowledge and thank the individuals and organizations which have been involved
during its private development.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done by hand due to overlapping edits

docs/project/going_public.md Outdated Show resolved Hide resolved
docs/project/going_public.md Outdated Show resolved Hide resolved
@sidney13 sidney13 added proposal accepted Decision made, proposal accepted and removed needs decision labels Nov 4, 2020
@sidney13
Copy link
Contributor

sidney13 commented Nov 4, 2020

The proposal was accepted on 2020-11-03. As per the decision, updates that do not change the key substance of the proposal may be approved by code review.

@sidney13 sidney13 self-requested a review November 4, 2020 14:15
Copy link
Contributor

@sidney13 sidney13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing review manager approval. Do not commit until other reviewers (minimally, chandlerc and zygloid) have approved.

Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (with one editorial suggestion). Per the core team decision, this also needs approval from @chandlerc.

docs/project/going_public.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also generally LGTM. I've made a really trivial editorial suggestion below that isn't material one way or another. But the discussion of tech press I think is best skipped for now. Approving with these suggested changes.

docs/project/going_public.md Outdated Show resolved Hide resolved
conference or in our own remote or physical event.
- A website.
- A social media game plan.
- Tech press lined up.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest omitting discussion of tech press at this stage... I think it is more likely to concern than reassure people.

Suggested change
- Tech press lined up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased to "A game plan for social media and tech press." -- are you okay with that? I'm okay avoiding the "lined up" phrasing, but I think it's an obvious enough issue that it's awkward to just avoid discussing. (also, note tech press is mentioned below for major leaks)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new wording is fine; we can iterate on this further after commit if needed.

Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, just want to see if you're okay with the edit

conference or in our own remote or physical event.
- A website.
- A social media game plan.
- Tech press lined up.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased to "A game plan for social media and tech press." -- are you okay with that? I'm okay avoiding the "lined up" phrasing, but I think it's an obvious enough issue that it's awkward to just avoid discussing. (also, note tech press is mentioned below for major leaks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes PR meets CLA requirements according to bot. proposal accepted Decision made, proposal accepted proposal A proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants