Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underline the complete declaration in diagnostics #3508

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Underline the complete declaration in diagnostics #3508

merged 5 commits into from
Dec 14, 2023

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Dec 14, 2023

Builds upon @domisterwoozy 's excellent #3442 . Removes the need to store the first node of a declaration in the declaration state stack.

zygoloid
zygoloid approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@zygoloid zygoloid added this pull request to the merge queue Dec 14, 2023
Merged via the queue into carbon-language:trunk with commit 23c7d7d Dec 14, 2023
8 checks passed
@josh11b josh11b deleted the highlight branch December 14, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zygoloid zygoloid zygoloid approved these changes

@chandlerc chandlerc Awaiting requested review from chandlerc

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@josh11b @zygoloid