Remove SelfParam, add an AddrPattern instead.
#3506
Conversation
This is intended to make the representation of a `self` pattern be more similar to other patterns.
| auto inst = sem_ir.insts().Get(param_id); | ||
| if (auto addr = inst.TryAs<SemIR::AddrPattern>()) { | ||
| inst = sem_ir.insts().Get(addr->inner_id); | ||
| } | ||
| if (auto param = inst.TryAs<SemIR::Param>(); | ||
| param && param->name_id == SemIR::NameId::SelfValue) { |
There was a problem hiding this comment.
This code matches what's in convert.cpp, differing only on what's done with param. Not sure it's worth a like TryGetAsSelfValueParam or similar, but might be worth considering.
There was a problem hiding this comment.
Maybe we can take another look once ConvertCallArgs is also handling deduced parameters. They might look less similar at that point.
| auto HandleAddrPattern(FunctionContext& /*context*/, SemIR::InstId /*inst_id*/, | ||
| SemIR::AddrPattern /*inst*/) -> void { | ||
| CARBON_FATAL() << "`addr` should be lowered by `BuildFunctionDefinition`"; | ||
| } |
There was a problem hiding this comment.
Is it worth moving all the fatal handlers to their own file, like handle_unused?
There was a problem hiding this comment.
Sure, will send a PR.
toolchain/sem_ir/formatter.cpp
Outdated
| // TODO: Visit the entire parameter block, not just the parameter | ||
| // refs, so that we visit the parameter inside an `addr` pattern. |
There was a problem hiding this comment.
Is this an issue where patterns generally need to be recursed through? I'll offer some concern that walking the entire parameter block might not yield the right result either, due to separate use of blocks.
There was a problem hiding this comment.
Switched TODO to just describe the problem rather than suggesting a solution.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This is intended to make the representation of a
selfpattern be more similar to other patterns.