Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a name is not found in a class, perform lookup into base classes. #3502

Merged
merged 7 commits into from
Dec 14, 2023
Merged

If a name is not found in a class, perform lookup into base classes. #3502

merged 7 commits into from
Dec 14, 2023

Conversation

zygoloid
Copy link
Contributor

@zygoloid zygoloid commented Dec 13, 2023 •
edited
Loading

This builds out a little infrastructure for one name scope to extend another. We'll need more refinement here to cover other cases, but this should provide some foundation for that future work.

jonmeow
jonmeow reviewed Dec 13, 2023
View reviewed changes
toolchain/sem_ir/value_stores.h Show resolved Hide resolved
toolchain/sem_ir/value_stores.h Outdated Show resolved Hide resolved
toolchain/sem_ir/value_stores.h Outdated Show resolved Hide resolved
toolchain/diagnostics/diagnostic_kind.def Outdated Show resolved Hide resolved
toolchain/check/check.cpp Show resolved Hide resolved
toolchain/check/handle_class.cpp Outdated Show resolved Hide resolved
toolchain/sem_ir/value_stores.h Show resolved Hide resolved
toolchain/check/context.cpp Show resolved Hide resolved
jonmeow
jonmeow approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving -- I think tests are important to add, but I imagine the code's mostly working as intended right now so it's mostly a documentation question.

jonmeow
jonmeow approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

toolchain/check/handle_class.cpp Outdated Show resolved Hide resolved
@zygoloid zygoloid added this pull request to the merge queue Dec 14, 2023
Merged via the queue into carbon-language:trunk with commit de0c02d Dec 14, 2023
6 checks passed
@zygoloid zygoloid deleted the toolchain-base-extend branch December 14, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmeow jonmeow jonmeow approved these changes

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zygoloid @jonmeow