Support derived to base conversions. #3487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
changed the title
jonmeow
approved these changes
Dec 11, 2023
| fn ConvertInit() { | ||
| let a: A = {.base = {.base = {.a = 1}, .b = 2}, .c = 3} as C; | ||
| } | ||
|
|
There was a problem hiding this comment.
I think the code works for it, but should there be some tests of non-class-type bases? e.g.:
Suggested change
| class StructBase { | |
| extend base: {.x: i32}; | |
| } | |
| fn ConvertStructBaseValue(v: StructBase) { | |
| let s: {.x: i32} = v; | |
| } | |
| fn ConvertStructBase(p: StructBase*) -> {.x: i32}* { return p; } |
There was a problem hiding this comment.
Done. Added to fail_base_bad_type.carbon because we don't allow such inheritance at all at the moment, but it seems good to make sure that it at least doesn't crash.
There was a problem hiding this comment.
LGTM, for some reason I was thinking it was allowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is enough to support calling methods that take a
BaseorBase*as theirself. But name lookup doesn't look in the base class yet, so base class methods aren't actually found.