Split out infix and prefix operators to separate node kinds. #3481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(note, dependencies in stack) |
jonmeow
force-pushed
the
op-split
branch
2 times, most recently
from
99ddac7
to
d3d6cd4
Compare
jonmeow
force-pushed
the
op-split
branch
2 times, most recently
from
1e1665d
to
159c37c
Compare
zygoloid
reviewed
Dec 13, 2023
| break; | ||
| } | ||
|
|
||
| context.PushState(state); | ||
| context.PushStateForExpr(operator_precedence); | ||
| } else { | ||
| context.AddNode(NodeKind::PostfixOperator, state.token, state.subtree_start, | ||
| state.has_error); | ||
| context.AddNode(NodeKind::PostfixOperatorStar, state.token, |
There was a problem hiding this comment.
Even if we only have one postfix operator for now, I think we should add a switch here and a ..._POSTFIX macro.
There was a problem hiding this comment.
Okay, I'll send a separate PR for that.
josh11b
approved these changes
Dec 13, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 14, 2023
Per request on #3481, for consistency with prefix/infix.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
Co-authored-by: Jon Ross-Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leaves a single state for each in the expr loop. I was trying to think through ways to have per-token states, but they felt sort of bulky.
Note this is more verbose: but I think the long-term is going to be that when we start wanting to add handlers, we're going to need to switch to different names based on the token found. As a consequence, the parse state logic will end up diverging a little, and we'll just want to align towards boilerplate handlers.
Short-term, this opens up a path for saying that each parse node corresponds to precisely one token in success states, and separates out what were becoming big handler functions in check.