Split out and/or operator handling from infix. #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmeow
force-pushed
the
and-or
branch
4 times, most recently
from
fd32239
to
d7a3cda
Compare
zygoloid
approved these changes
Dec 8, 2023
toolchain/parse/state.def
Outdated
| @@ -488,7 +493,7 @@ CARBON_PARSE_STATE(ExprLoop) | |||
| // Completes an ExprLoop pass by adding an infix operator, then goes back | |||
| // to ExprLoop. | |||
| // | |||
| // expr <binary operator> expr ... | |||
| // expr <infix operator> expr ... | |||
| // ^ | |||
There was a problem hiding this comment.
Suggested change
| // ^ | |
| // ^ |
toolchain/parse/state.def
Outdated
| @@ -471,7 +471,7 @@ CARBON_PARSE_STATE(ExprInPostfixLoop) | |||
|
|
|||
| // Handles processing of an expression. | |||
| // | |||
| // expr <binary operator> ... | |||
| // expr <infix operator> ... | |||
| // ^~~~~~~~~~~~~~~~~ | |||
There was a problem hiding this comment.
Suggested change
| // ^~~~~~~~~~~~~~~~~ | |
| // ^~~~~~~~~~~~~~~~ |
toolchain/parse/state.def
Outdated
Comment on lines
483
to
484
| // expr <short circuit operator> ... | ||
| // ^~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
Suggested change
| // expr <short circuit operator> ... | |
| // ^~~~~~~~~~~~~~~~~ | |
| // expr <short circuit operator> ... | |
| // ^~~~~~~~~~~~~~~~~~~~~~~~ |
toolchain/parse/state.def
Outdated
Comment on lines
512
to
513
| // expr <short circuit operator> expr ... | ||
| // ^ |
There was a problem hiding this comment.
Isn't this here:
Suggested change
| // expr <short circuit operator> expr ... | |
| // ^ | |
| // expr <short circuit operator> expr ... | |
| // ^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is also doing the parse node split, allowing lower reliance in formatter on the tokenized buffer (something that I may be touching more due to import handling).