Add interface support to check #3474
Conversation
toolchain/check/handle_interface.cpp
Outdated
| // TODO: do we need this for an interface? | ||
| context.args_type_info_stack().Push(); |
There was a problem hiding this comment.
Do we want to create a witness table for interfaces? (I think we might -- even if we don't use them at runtime, I think we'll probably want a compile-time representation for them.) If we do, I think this stack would be the most consistent place to build one.
If not -- or not for now -- then we can remove this and the pop below.
There was a problem hiding this comment.
I am not sure, but if so I think it would be in a later change.
toolchain/check/modifiers.cpp
Outdated
| if (auto kind = context.current_scope_kind()) { | ||
| if (*kind == SemIR::InterfaceDecl::Kind) { | ||
| // Both `default` and `final` allowed in an interface definition. | ||
| return; | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe you could simplify this to:
| if (auto kind = context.current_scope_kind()) { | |
| if (*kind == SemIR::InterfaceDecl::Kind) { | |
| // Both `default` and `final` allowed in an interface definition. | |
| return; | |
| } | |
| } | |
| if (context.GetCurrentScopeAs<SemIR::InterfaceDecl>()) { | |
| // Both `default` and `final` allowed in an interface definition. | |
| return; | |
| } |
(I think this ends up doing slightly more work, but I'd expect it to optimize to the same thing.)
Or if not that, then maybe we could add a CurrentScopeIs<Kind>? It looks like the other caller of current_scope_kind would also benefit from this change.
There was a problem hiding this comment.
Created and switched to CurrentScopeIs<Kind>.
Largely copied from the
classcode