Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish making clang-tidy (mostly) work (again) and run -fix #2312

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Oct 18, 2022

This does some more work to the run_clang_tidy.py wrapper script, and runs an example pass.

"again" because it's really the proto fuzzer changes that broke it, it had been working before.

"mostly" because there's still an issue within the proto fuzzer that it can't find "port/protobuf.h", i.e. https://github.com/google/libprotobuf-mutator/tree/master/port, but I'm still hesitant to add an include path there.

@jonmeow
Copy link
Contributor Author

jonmeow commented Oct 18, 2022

This is #2310 but fixed the source branch.

Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jonmeow jonmeow merged commit 4d522c8 into carbon-language:trunk Oct 18, 2022
@jonmeow jonmeow deleted the fix-tidy branch October 18, 2022 22:48
@chandlerc chandlerc added toolchain explorer Action items related to Carbon explorer code labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
explorer Action items related to Carbon explorer code toolchain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants