Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a toolchain team. #179

Merged
merged 12 commits into from
Jan 17, 2021
Merged

Create a toolchain team. #179

merged 12 commits into from
Jan 17, 2021

Conversation

chandlerc
Copy link
Contributor

@chandlerc chandlerc commented Oct 25, 2020 •
edited
Loading

Create a team to oversee the development of Carbon's toolchain. This
team is responsible for code reviews as well as handling any
toolchain-specific decisions.

@chandlerc chandlerc added WIP proposal A proposal labels Oct 25, 2020
@google-cla google-cla bot added the cla: yes PR meets CLA requirements according to bot. label Oct 25, 2020
@chandlerc chandlerc requested a review from a team October 25, 2020 10:43
@chandlerc
Create a toolchain team.
397b443 
Create a team to oversee the development of Carbon's toolchain. This
team is responsible for code reviews as well as handling any
toolchain-specific decisions.
@chandlerc chandlerc added proposal rfc Proposal with request-for-comment sent out and removed WIP labels Oct 25, 2020
@chandlerc
Copy link
Contributor Author

Posting this for an RFC -- pretty minor proposal overall.

jonmeow
jonmeow reviewed Oct 27, 2020
View reviewed changes
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM, although thinking non-proposal documentation should be clearer

docs/project/groups.md Outdated
@@ -61,3 +61,9 @@ For most purposes, the Core team should be contacted about conduct issues.
- Discord Chat role: review-managers
- [Google group](https://groups.google.com/g/carbon-lang-review-managers):
Grants Google Drive access.

### Toolchain team
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file start having short descriptions of the teams?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. I've added one for the toolchain team to the proposal.

We should also probably rotate the "admins" into an "infrastructure team" or something similar, but I figure that can happen later if/when relevant.

chandlerc
chandlerc commented Nov 21, 2020
View reviewed changes
Copy link
Contributor Author

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Updated a bit to expand on the scope of this and implications. I'll also ask for a review manager and hopefully set a comment deadline ASAP (given holidays and such).

docs/project/groups.md Outdated
@@ -61,3 +61,9 @@ For most purposes, the Core team should be contacted about conduct issues.
- Discord Chat role: review-managers
- [Google group](https://groups.google.com/g/carbon-lang-review-managers):
Grants Google Drive access.

### Toolchain team
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. I've added one for the toolchain team to the proposal.

We should also probably rotate the "admins" into an "infrastructure team" or something similar, but I figure that can happen later if/when relevant.

jonmeow
jonmeow reviewed Nov 23, 2020
View reviewed changes
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm realizing I'm mostly commenting on the proposal edits. Take them or leave them, I had been thinking that was the actual doc.

proposals/p0179.md Outdated Show resolved Hide resolved
proposals/p0179.md Outdated Show resolved Hide resolved
proposals/p0179.md Outdated Show resolved Hide resolved
docs/project/groups.md Outdated Show resolved Hide resolved
@sidney13 sidney13 added comment deadline and removed proposal rfc Proposal with request-for-comment sent out comment deadline labels Nov 25, 2020
austern
austern reviewed Dec 1, 2020
View reviewed changes
proposals/p0179.md Outdated Show resolved Hide resolved
geoffromer
geoffromer reviewed Dec 1, 2020
View reviewed changes
proposals/p0179.md Outdated Show resolved Hide resolved
proposals/p0179.md Outdated Show resolved Hide resolved
@chandlerc
Copy link
Contributor Author

While this is still under decision, essentially all the comments were completely trivial punctuation, spelling, and word choice fixes with no impact on the document as a whole so I've applied them. Sorry for all the typos.

sidney13
sidney13 approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@sidney13 sidney13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposal has been accepted on 2020-12-08. Announcement thread.

@sidney13 sidney13 added proposal accepted Decision made, proposal accepted and removed needs decision labels Dec 9, 2020
@chandlerc
Copy link
Contributor Author

Updated to call the team the "implementation team" in the actual project docs, but I've left the proposal pristine and as it was viewed by the core team.

@chandlerc
Copy link
Contributor Author

Ping @jonmeow and @zygoloid (both as members of the implementation team, the latter as also a core-team representative).

sidney13 added a commit that referenced this pull request Dec 30, 2020
@sidney13
Decision for #179: Create a Toolchain Team (#225)
e34809f
sidney13
sidney13 approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@sidney13 sidney13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Community comment period has ended. PR approved.

@chandlerc chandlerc merged commit cee2bd4 into carbon-language:trunk Jan 17, 2021
@chandlerc chandlerc deleted the toolchain-team branch January 17, 2021 00:07
chandlerc added a commit that referenced this pull request Jan 17, 2021
@chandlerc
Update proposal list after #179. (#239)
f4a31ab 
I thought the PR checks would have caught and prevented this, but
I think it predated them or they didn't catch it.
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
@sidney13
Decision for #179: Create a Toolchain Team (#225)
f42da8f
chandlerc added a commit that referenced this pull request Jun 28, 2022
@chandlerc @jonmeow
@austern @geoffromer
Create an implementation team. (#179)
5db229a 
Create a team to oversee the implementation of Carbon. This team is
responsible for code reviews as well as handling any implementation-specific
decisions.

Originally, it was suggested to call this a "toolchain" team. During
discussion, it became clear that the scope wasn't easily limited to
implementation efforts that were necessarily part of the toolchain. There are
many different aspects of implementation, and we anticipate code sharing
between them that make it unhelpful to try to separate these. Instead, this
team is chartered with broadly covering all of the implementation concerns in
Carbon. If someone is concerned that an issue is larger than that, perhaps
impacting the design of the language, the project, or the community, the
standard process already provides for easy escalation to the core team.

Co-authored-by: Jon Meow <[email protected]>
Co-authored-by: austern <[email protected]>
Co-authored-by: Geoff Romer <[email protected]>
chandlerc added a commit that referenced this pull request Jun 28, 2022
@chandlerc
Update proposal list after #179. (#239)
51b98b1 
I thought the PR checks would have caught and prevented this, but
I think it predated them or they didn't catch it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austern austern austern left review comments

@geoffromer geoffromer geoffromer left review comments

@zygoloid zygoloid zygoloid approved these changes

@sidney13 sidney13 sidney13 approved these changes

@jonmeow jonmeow jonmeow approved these changes

Assignees
No one assigned
Labels
cla: yes PR meets CLA requirements according to bot. proposal accepted Decision made, proposal accepted proposal A proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@chandlerc @zygoloid @austern @geoffromer @sidney13 @jonmeow