fix(PageHeader): enable canary ActionBar inside of PageHeader
#5332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
szinta
approved these changes
May 29, 2024
elycheea
approved these changes
May 30, 2024
Merged
via the queue into
carbon-design-system:main
with commit May 30, 2024
662bbe2
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4979
When we moved the
ActionBarfrom internal to canary it caused issues in the PageHeader because it wasn't being enabled (which is required for all canary components), whether they are used within our@carbon/ibm-productscomponents or elsewhere.The bug can be reproduced locally by removing the following two lines in
packages/core/.storybook/preview.js. Explicitly enabling theActionBarwithin thePageHeadercomponent fixed this issue.This stack blitz reproduces the issue.
What did you change?
How did you test and verify your work?
Removed enabling of all canary components locally within storybook and verified that the canary message is gone and the component renders after adding
pkg.component.ActionBar = true;toPageHeader.tsx.