Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(APIKeyModal): add default state AVT check #5111

Merged
merged 3 commits into from
May 13, 2024

Conversation

makafsal
Copy link
Contributor

@makafsal makafsal commented May 8, 2024

Contributes to #4661

What did you change?

Create file: e2e/components/APIKeyModal/APIKeyModal-test.avt.e2e.js

How did you test and verify your work?

yarn avt

@makafsal makafsal requested a review from a team as a code owner May 8, 2024 11:13
@makafsal makafsal requested review from elycheea and amal-k-joy and removed request for a team May 8, 2024 11:13
Copy link

netlify bot commented May 8, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 34fd9c0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/664206c13aba6700085b725f
😎 Deploy Preview https://deploy-preview-5111--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@matthewgallo matthewgallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another case where you have to click the button on the story page in order for the modal to be visible before running the a11y check.

Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@amal-k-joy amal-k-joy self-requested a review May 13, 2024 12:13
@makafsal makafsal enabled auto-merge May 13, 2024 12:25
@makafsal makafsal disabled auto-merge May 13, 2024 12:25
@matthewgallo matthewgallo added this pull request to the merge queue May 13, 2024
Merged via the queue into carbon-design-system:main with commit 02a2e1e May 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants