Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tag): fixes disabled label styles #16943

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lluisrojass
Copy link
Contributor

Closes #16942

Fixes read only tag disabled state.

Changelog

New

  • _tag.scss adds disabled styles directly to .cds--tag__label element in order to overwrite <DefinitionTooltip /> styles which would usurp .cds--tag--disabled

Changed

  • Removes the type class name from the label (this is still applied via tagClasses)

Testing / Reviewing

  • Validate Tag UI

@lluisrojass lluisrojass requested a review from a team as a code owner July 10, 2024 20:30
Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 857bcd6
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66917b86dc465e0008d177b1
😎 Deploy Preview https://deploy-preview-16943--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 857bcd6
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66917b86ed408500086f0c94
😎 Deploy Preview https://deploy-preview-16943--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: <Tag /> disabled state is broken
1 participant