Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Plausible to v2.1.1 #1130

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

abhranil26
Copy link
Contributor

@abhranil26 abhranil26 commented Jul 11, 2024

Added a new env variable TOTP_VAULT_KEY which is now a requirement. Updated clickhouse and postgres versions too!
Testing on personal caprover instance and its working.

First of all, thank you for your contribution! 😄

Please note that this repo is mostly for popular apps with thousands of stars and tens of thousands of downloads. If you'd like to add a less popular app, you can always create your own 3rd party repo and add your app there.

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.
  • I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter (If failling run the prettier: npm run formatter-write)
  • I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

@githubsaturn
Copy link
Collaborator

Thanks!

@githubsaturn githubsaturn merged commit bd052ec into caprover:master Jul 14, 2024
1 check passed
- description: This new key is used to encrypt TOTP secrets at rest. Generate by running $ openssl rand -base64 32
id: $$cap_TOTP_VAULT_KEY
label: TOTP_VAULT_KEY
defaultValue: aihU7k+GSBKbcVFuX9VEPyUhuwlKEomqA94/SQQ0NR4=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice this hardcoded value as a default value. It poses a security risk. I'll remove this default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants