Add tabDragSpeed global attribute #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealus
approved these changes
Nov 1, 2018
|
@nealus thanks for merging this. Would you be able to publish to npm sometime in the near future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the CSS transition speed for the tab drag outline was hard-coded at 0.3 seconds. I found this to be a bit slow for my taste. This PR would make it customizable via a global attribute.
Another option would be to move it out of code and into CSS. Both options have pros and cons, but an attribute met my needs well, so I went with that. If you disagree with the approach, I'm happy to discuss.
If you want to rename
tabDragSpeedto something else, I don't mind. I just care about the functionality.Thank you!