Fixes #1582 #1597
Merged
Fixes #1582 #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that method pass the
errontoeachOfLimit, so that they can be canceled properly. The one method I'm not quite sure about istryEach. I'm assuming that sinceretryis cancelable,tryEachshould be too?Sorry if I went a little overboard with the tests, I ended up going down a rabbit hole 😅. For the tests, I was trying to follow the coding style of the encompassing file, which is why some of the descriptions and styles vary. I figured it would be better to keep consistent logging and for future maintenance.