-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How is Async going to support concat functions? #1437
Comments
Looks like we're just doing a truthy check here, when we should actually do https://github.com/caolan/async/blob/master/lib/internal/concat.js#L5 |
hargasinski
added a commit
that referenced
this issue
Jun 13, 2017
Sure, I'll follow the PR changes, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of async are you using?
v2.4.1
Which environment did the issue occur in (Node version/browser version)
Node v8.0.0
What did you do? Please include a minimal reproducable case illustrating issue.
What did you expect to happen?
If the function has the same functionality as
Array.prototype.concat
, it should be[1, 0, 3]
.What was the actual result?
[1, 3]
Also I realized,
I would like to know how Async is going to support the functions. Thanks :)
The text was updated successfully, but these errors were encountered: