-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't call auto tasks filter
(or any other method of Array.prototype).
#1358
Labels
Comments
I have a fix for this. I couldn't reproduce the error in a test case for some reason, but I see exactly how it is caused. |
hargasinski
added a commit
to hargasinski/async
that referenced
this issue
Mar 28, 2017
generated from commit 8903d46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of async are you using?
2.1.4
Which environment did the issue occur in (Node version/browser version)
Node 6.9.4
What did you do? Please include a minimal reproducable case illustrating issue.
What did you expect to happen?
Logs error but doesn't raise exception.
What was the actual result?
This is because of:
listeners
variable initially declared as an object, being transformed to array at some point (line 1614) for some reason, which is a bad idea in general.hasOwnProperty
check. Someone might as well call taskhasOwnProperty
.The text was updated successfully, but these errors were encountered: