-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error filter for retry and retryable #1256
Labels
Comments
I'd be open to this |
bojand
changed the title
error filter for retry and retriable
error filter for retry and retryable
Jul 28, 2016
Sounds good. When we added the interval function, we also wanted to add a way to handle errors differently, but couldn't think of a good way to expose that in the API. This seems like a good way to do it. |
megawac
added a commit
that referenced
this issue
Aug 8, 2016
add filter option to retry() and retryable(). PR for #1256.
hargasinski
pushed a commit
to hargasinski/async
that referenced
this issue
Oct 7, 2016
…ring and control of retry flow. Resolves caolan#1256.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
I did q quick search and didn't find similar issue... It would be useful to have
retry
andretryable
accept an optionalerrorFilter
sync function that will only allow the retry to continue if the function returnstrue
. for example something like:This could be done in backwards compatible manner. Opinions? Would this be something accepted? I could probably try and do a PR sometime next week if so.
Thanks,
Bojan
The text was updated successfully, but these errors were encountered: