Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure at least MCFLY_HISTFILE is set for history import #315

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Ensure at least MCFLY_HISTFILE is set for history import #315

merged 1 commit into from
Dec 16, 2022

Conversation

cantino
Copy link
Owner

@cantino cantino commented Dec 14, 2022

Maybe fix #313?

@cantino cantino mentioned this pull request Dec 14, 2022
Closed
sapiderman
sapiderman approved these changes Dec 15, 2022
View reviewed changes
Copy link

@sapiderman sapiderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR Fixed the issue for me 🍻 🍷 👍🏽 !!

Running on bash on:

Distributor ID:	Pop
Description:	Pop!_OS 22.04 LTS
Release:	22.04
Codename:	jammy

Screenshot

Top is before the patch, bottom after the patch
image

Thank you!

ChristopherMacGown added a commit to ChristopherMacGown/devcontainer-features that referenced this pull request Dec 15, 2022
@ChristopherMacGown
Fix crash in mcfly latest when MCFLY_HISTFILE is not set.
21f62ef 
Until cantino/mcfly#315 lands, mcfly will crash trying to load the
history file, because it cannot explicitly see that it is set in the
shell using the shell's HISTFILE environment variable.

I also switched how the shell initialization happens. Instead of calling
eval, we just source the output of mcfly init <shell>.
@ChristopherMacGown ChristopherMacGown mentioned this pull request Dec 15, 2022
Merged
ChristopherMacGown added a commit to ChristopherMacGown/devcontainer-features that referenced this pull request Dec 15, 2022
@ChristopherMacGown
Fix crash in mcfly latest when MCFLY_HISTFILE is not set.
09842a1 
Until cantino/mcfly#315 lands, mcfly will crash trying to load the
history file, because it cannot explicitly see that it is set in the
shell using the shell's HISTFILE environment variable.

I also switched how the shell initialization happens. Instead of calling
eval, we just source the output of mcfly init <shell>.
@cantino cantino merged commit 574e5a8 into master Dec 16, 2022
@cantino cantino deleted the export-MCFLY_HISTFILE branch December 16, 2022 05:10
@cantino
Copy link
Owner Author

cantino commented Dec 16, 2022

Thanks for confirming @sapiderman!

@dedguy21 dedguy21 mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapiderman sapiderman sapiderman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

thread 'main' panicked at 'McFly error: Please ensure HISTFILE or MCFLY_HISTFILE is set
2 participants
@cantino @sapiderman