Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid exporting HISTFILE #308

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Avoid exporting HISTFILE #308

merged 1 commit into from
Dec 10, 2022

Conversation

cantino
Copy link
Owner

@cantino cantino commented Dec 8, 2022

Hopefully fixes 249.

@cantino
Copy link
Owner Author

cantino commented Dec 8, 2022

@dithpri (or @AndrewKvalheim, if you're open to it... you've already suffered enough), would you be able to test this?

@dithpri
Copy link

dithpri commented Dec 9, 2022

From the quick testing I've done (the repro described in 249), this works.
I think this is also much better than the solution I had suggested -- and obviously forgot about, for which I apologize -- since it avoids exporting HISTFILE completely, not even as MCFLY_HISTFILE.

From a glance at the code, this could break compatibility with fish, as mcfly.fish wasn't updated to not use MCFLY_HISTFILE. I have however no experience with fish and just running it with the default mcfly setup has produced no errors. Ok, so I think the fish script uses a different way of adding commands. Is MCFLY_HISTFILE still needed there?

@cantino
Copy link
Owner Author

cantino commented Dec 10, 2022

Thanks @dithpri!

I'm honestly not 100% sure if fish needs it anymore. The only code path that seems like it'd hit it for fish would be calls to shell_history::history_file_path, and then only if HISTFILE isn't set.

@cantino cantino merged commit ffb1ed4 into master Dec 10, 2022
@cantino cantino deleted the avoid-exporting-histfile branch December 10, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants