-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge in updated libraries from Cantaloup 5.0.6 and fix test failures #656
Conversation
…OperationList.applyNonEndpointMutations() (fixes cantaloupe-project#589)
….0.6 Cantaloup 5.0.6
…tableOutputStream
The MapReader class is only being used by XMPElements() which is not being used in Cantaloupe
Hi @angelahuqing, thank you for submitting this pull request and doing all of the work to bring in the changes. Are you able to make the Cantaloupe meeting later? I've had a look at the code and there are a few changes which seem wider than just the library version update. Specificlly:
I'm happy to close my pull request (#653) in favour of this one but just want to check we aren't removing needed functionality. Thanks |
Hi @glenrobson I think I may have missed the meeting, but if you let me know when the next one is, I can try and attend. To give you some more context on the changes I made, all of the changes came as a result of failing tests in the GA. Anything that I removed was because it was a direct cause of a failing test. I also cross-checked with the 5.0.6 release to see what hadn't been automatically merged and deduced from that what could be removed. For example
|
Ah I can see that the XMP Elements were added here to the develop branch. I can't see a related issue requesting this feature but useful to know its something new. Also the multipart upload for s3 was added here and we discussed in the meeting that this would help with large images that are cached. Is there a way we could look at fixing the breaking tests for XMP and s3 without removing them? |
I think it's possible to fix the tests for XMP and s3. I didn't look into it too much because this PR was focused on getting the merge between dev and 5.0.6 done without failures so that the security issues would be fixed. I don't necessarily know if I will have the time to debug them, but I think someone theoretically could. |
@glenrobson will continue working on merging libraries from 5.0.6 in #668. As a result this PR will be closed and all future work will be done on that pull request. |
5.0.6 is merged into develop branch as well as replacing or removing tests/functions that aren't being used and causing failure.