ISSUE-593: Fix Virtual Cropping detection condition to take both Y and X in account #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksclarke
approved these changes
May 14, 2024
|
Just looking through the original #482 issue it looks like this was fixed in 5.0.2 but came back in 5.0.4. Although its a simple fix I think it would be useful to include a test to make sure this doesn't get re-introduced. |
|
@glenrobson my understanding is it was not completely fixed by fff5425 (typo in that fix) thus my pull. I can write a test but only by July 2024 (sorry), my June availability because of day-work and conferences is very limited. |
|
Glen to add to test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #593
Fixes a bug generated by a small typo. Without this fix, PDF tile generation will only result in a single axis being tiled.