cleanup: Start of no-implicit-bool compliance; use prefix-increment. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I try to keep the C++-isms to a minimum in CMP and I'm not convinced of the benefits here. I did pull in the CI changes (thanks!), but I think unless there are errors in C++ compilers that can only be fixed by switching from idiomatic C to idiomatic C++ I don't think this is necessary. Could be convinced though! |
Semantics of postfix-increment are to return the value it had before the increment, encouraging code like `f(..., b++)`, which is better written as `f(..., b); ++b;` to avoid doing too many possibly mutating operations in one statement/expression.
|
Ok, I've reverted the |
|
OK I can live with that, thanks for doing it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semantics of postfix-increment are to return the value it had before the increment, encouraging code like
f(..., b++), which is better written asf(..., b); ++b;to avoid doing too many possibly mutating operations in one statement/expression.