Make squirt recognise spaces before elements #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I haven't been engaged with this today—spent most of my dev time banging my head against DNS/SSL issues (with success, thankfully—squirt.io is now https enabled). Have a question about the regex.. |
| @@ -490,7 +490,7 @@ var readability = { | |||
| child = node.childNodes[childIdx]; | |||
| nodeName = child.nodeName.toLowerCase(); | |||
| if(nodeName == "#text"){ | |||
| text += child.nodeValue.trim('\n'); | |||
| text += child.nodeValue.replace(/^\n+/, "").replace(/\n+$/, ""); | |||
There was a problem hiding this comment.
How is this different from trim? Looking at the trim docs on MDN, they suggest almost the same regex (/^\s+|\s+$/g). Not sure how this would address the issue of spaces.
There was a problem hiding this comment.
Yes, but \s means all whitespace.
Firefox and Chrome:
> "\n abc \n".trim()
"abc"
So this is where the spaces are being wrongly removed. If you merge this patch, you'll see that it fixes the problem.
There was a problem hiding this comment.
Ah, I see—trim doesn't accept an argument, so passing '\n' was ineffective...
cameron
added a commit
that referenced
this pull request
Mar 17, 2014
Make squirt recognise spaces before elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #39 (previously #72) where squirt would not recognise spaces before inline elements such as hyperlinks.