Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(event_tags): Add event_tags table and migration script #349

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

imksoo
Copy link
Collaborator

@imksoo imksoo commented Jan 8, 2024

Description

This pull request introduces a new event_tags table and its associated migration script. By expanding and indexing the contents of the tags field of the events table in the events_tags table in advance, the search process by REQ can be made much faster than the original JSONB operation.

Related Issue

#348

Motivation and Context

The addition of the event_tags table is required to efficiently manage and query event tag data. This change aims to improve data organization and access, facilitating better event management within the application.

How Has This Been Tested?

The changes have been tested in a local development environment. I performed the following tests:

  • Successfully ran the migration script to create the event_tags table.
  • Inserted sample data into the event_tags table and verified its integrity.
  • Checked that the new table does not adversely affect other areas of the code.

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7443641804

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 50.589%

Totals Coverage Status
Change from base Build 6132344305: 0.1%
Covered Lines: 1189
Relevant Lines: 2298

💛 - Coveralls

@cameri cameri merged commit 9bf0262 into cameri:main Jan 8, 2024
7 of 10 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 12, 2024
# [1.26.0](v1.25.2...v1.26.0) (2024-01-12)

### Bug Fixes

* `invoice.verifyURL` undefined from lnurl processor getInvoice ([#325](#325)) ([33c2fd5](33c2fd5))
* deleting parameterized replaceable event before event ([#354](#354)) ([030bbb3](030bbb3))
* strange behavior with nip 33 parameterized replacable events and nip 40 expiration tag ([#316](#316)) ([d1d4cb9](d1d4cb9))
* typos ([#334](#334)) ([3b5b1fc](3b5b1fc))

### Features

* add nodeinfo support ([#347](#347)) ([d9e4020](d9e4020))
* **event_tags:** Add event_tags table and migration script ([#349](#349)) ([9bf0262](9bf0262))
Copy link

🎉 This PR is included in version 1.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants