Sourcery refactored master branch #1

sourcery-ai · 2023-04-16T01:15:06Z

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai · 2023-04-16T01:15:08Z

backtracking/subsets.py

- print('Number of subsets: {}'.format(len(solutions)))
+ print(f'Number of subsets: {len(solutions)}')


Function main refactored with the following changes:

Replace call to format with f-string (use-fstring-for-formatting)

sourcery-ai · 2023-04-16T01:15:09Z

bit_manipulation/bits.py

- for x in range(0, 20):
+ for x in range(20):


Function main refactored with the following changes:

Replace range(0, x) with range(x) [×5] (remove-zero-from-range)

Use f-string instead of string concatenation [×18] (use-fstring-for-concatenation)

Remove unnecessary casts to int, str, float or bool [×7] (remove-unnecessary-cast)

sourcery-ai · 2023-04-16T01:15:09Z

convex-hull/convex-hull.py

- difference = (
- ((p2.x - origin.x) * (p1.y - origin.y))
- - ((p1.x - origin.x) * (p2.y - origin.y))
+ return ((p2.x - origin.x) * (p1.y - origin.y)) - (
+ (p1.x - origin.x) * (p2.y - origin.y)
 )

- return difference


Function ConvexHull._get_orientation refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2023-04-16T01:15:09Z

convex-hull/convex-hull.py

- # get the first point (initial max) to use to compare with others
- p1 = None
- for p in points:
- if p is point:
- continue
- else:
- p1 = p
- break
-
+ p1 = next((p for p in points if p is not point), None)
 far_point = p1

 for p2 in points:
- # ensure we aren't comparing to self or pivot point
 if p2 is point or p2 is p1:
 continue
- else:
- direction = self._get_orientation(point, far_point, p2)
- if direction > 0:
- far_point = p2
+ direction = self._get_orientation(point, far_point, p2)
+ if direction > 0:
+ far_point = p2


Function ConvexHull.compute_hull refactored with the following changes:

Use the built-in function next instead of a for-loop (use-next)

Remove redundant continue statement (remove-redundant-continue)

Remove unnecessary else after guard condition (remove-unnecessary-else)

This removes the following comments ( why? ):

# get the first point (initial max) to use to compare with others # ensure we aren't comparing to self or pivot point

sourcery-ai · 2023-04-16T01:15:09Z

disjoint-sets/disjoint-sets.py

- else:
- # path compression
- self.hierarchy[item_id] = self.find(self.hierarchy[item_id])
- return self.hierarchy[item_id]
+ # path compression
+ self.hierarchy[item_id] = self.find(self.hierarchy[item_id])
+ return self.hierarchy[item_id]


Function DisjointSets.find refactored with the following changes:

Remove unnecessary else after guard condition (remove-unnecessary-else)

sourcery-ai · 2023-04-16T01:15:12Z

experiments/sockets/fib.py

- if n <= 2:
- return 1
-
- return fib(n - 1) + fib(n - 2)
+ return 1 if n <= 2 else fib(n - 1) + fib(n - 2)


Function fib refactored with the following changes:

Lift code into else after jump in control flow (reintroduce-else)

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-04-16T01:15:12Z

graphs/directed_graph_list.py

- for v in self.adjacency_list:
- yield v
+ yield from self.adjacency_list


Function DirectedGraph.get_vertex refactored with the following changes:

Replace yield inside for loop with yield from (yield-from)

sourcery-ai · 2023-04-16T01:15:12Z

graphs/directed_graph_list.py

- for u in self.adjacency_list[vertex]:
- yield u
+ yield from self.adjacency_list[vertex]


Function DirectedGraph.get_neighbor refactored with the following changes:

Replace yield inside for loop with yield from (yield-from)

sourcery-ai · 2023-04-16T01:15:13Z

graphs/directed_graph_list.py

- for u in reversed_list[vertex]:
- yield u
+ yield from reversed_list[vertex]


Function DirectedGraph.get_reverse_neighbor refactored with the following changes:

Replace yield inside for loop with yield from (yield-from)

sourcery-ai · 2023-04-16T01:15:13Z

graphs/directed_graph_list.py

- for u in self.get_neighbor(v):
- if u not in statuses:
- to_visit.append(u)
-
+ to_visit.extend(u for u in self.get_neighbor(v) if u not in statuses)


Function DirectedGraph.topological_sort refactored with the following changes:

Replace a for append loop with list extend (for-append-to-extend)

sourcery-ai · 2023-04-16T01:15:18Z

graphs/directed_graph_list.py

- components = self.scc_dfs_reverse_pass(stack)
-
- return components
+ return self.scc_dfs_reverse_pass(stack)


Function DirectedGraph.strongly_connected_components refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2023-04-16T01:15:18Z

graphs/undirected_graph_matrix.py

- for i in range(vertices):
- self.adjacency_matrix.append([0] * vertices)
+ self.adjacency_matrix.extend([0] * vertices for _ in range(vertices))


Function UndirectedGraph.__init__ refactored with the following changes:

Replace unused for index with underscore (for-index-underscore)

Replace a for append loop with list extend (for-append-to-extend)

sourcery-ai · 2023-04-16T01:15:19Z

graphs/undirected_graph_matrix.py

- colorings = {}
 to_visit = queue.Queue()
 to_visit.put(0)
- colorings[0] = 0
-
+ colorings = {0: 0}


Function UndirectedGraph.is_bipartite refactored with the following changes:

Move assignment closer to its usage within a block (move-assign-in-block)

Merge dictionary assignment with declaration (merge-dict-assign)

sourcery-ai · 2023-04-16T01:15:19Z

graphs/undirected_graph_weighted.py

- for e in self.adjacency_list[vertex]:
- yield e
+ yield from self.adjacency_list[vertex]


Function GraphUndirectedWeighted.get_neighbor refactored with the following changes:

Replace yield inside for loop with yield from (yield-from)

sourcery-ai · 2023-04-16T01:15:19Z

graphs/undirected_graph_weighted.py

- for v in range(self.vertex_count):
- yield v
+ yield from range(self.vertex_count)


Function GraphUndirectedWeighted.get_vertex refactored with the following changes:

Replace yield inside for loop with yield from (yield-from)

sourcery-ai · 2023-04-16T01:15:20Z

linked_lists/linked_list.py

- output += str(current) + " -> "
+ output += f"{str(current)} -> "


Function LinkedList.__str__ refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2023-04-16T01:15:20Z

machine-learning/line-count.py

-count = 0
-for line in sys.stdin:
- count += 1
-
+count = sum(1 for _ in sys.stdin)


Lines 3-6 refactored with the following changes:

Convert for loop into call to sum() (sum-comprehension)

Replace unused for index with underscore (for-index-underscore)

sourcery-ai · 2023-04-16T01:15:21Z

maximum_flow/max-flows.py

- return "%s->%s:%s" % (self.source, self.sink, self.capacity)
+ return f"{self.source}->{self.sink}:{self.capacity}"


Function Edge.__repr__ refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-04-16T01:15:21Z

merge_sort/main.py

- found = False
- for j in arr2:
- if i == j:
- found = True
- break
+ found = any(i == j for j in arr2)


Function contain_same_ints refactored with the following changes:

Use any() instead of for loop (use-any)

sourcery-ai · 2023-04-16T01:15:21Z

quick_sort/main.py

- found = False
- for j in arr2:
- if i == j:
- found = True
+ found = any(i == j for j in arr2)


Function contain_same_ints refactored with the following changes:

Use any() instead of for loop (use-any)

'Refactored by Sourcery'

5fa5cc4

sourcery-ai bot requested a review from camer0nluo April 16, 2023 01:15

sourcery-ai bot commented Apr 16, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sourcery refactored master branch #1

Sourcery refactored master branch #1

sourcery-ai bot commented Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

sourcery-ai bot Apr 16, 2023

		print('Number of subsets: {}'.format(len(solutions)))
		print(f'Number of subsets: {len(solutions)}')

		output += str(current) + " -> "
		output += f"{str(current)} -> "

		return "%s->%s:%s" % (self.source, self.sink, self.capacity)
		return f"{self.source}->{self.sink}:{self.capacity}"

Sourcery refactored master branch #1

Are you sure you want to change the base?

Sourcery refactored master branch #1

Conversation

sourcery-ai bot commented Apr 16, 2023

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Apr 16, 2023

Choose a reason for hiding this comment