Feat: missing titleStyle and descriptionStyle for List.Accordion and List.Section #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaysbytes Could you add also typescript types? |
|
Of course @Trancever, I forgot about that 😱 |
|
Hey @jaysbytes, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API. |
|
@Trancever typescript type landed on the branch |
ferrannp
approved these changes
Apr 25, 2019
|
@jaysbytes any idea when this will be released? It's not in the latest stable or even Alpha it seems. |
|
@twhitacre v2.16.0 should be available on npm! |
iyadthayyil
pushed a commit
to iyadthayyil/react-native-paper
that referenced
this pull request
Jun 6, 2019
…List.Section (callstack#997) This PR introduces missing style props: List.Accordion: - `titleStyle` - `descriptionStyle` List.Section - `titleStyle` Also improves `style` prop type and description in these components. ### Motivation Fixes callstack#973
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces missing style props:
List.Accordion:
titleStyledescriptionStyleList.Section
titleStyleAlso improves
styleprop type and description in these components.Motivation
Fixes #973
Test plan
You can play around by passing these props to List.Accordion and List.Section examples.