Check if manager is not null for update and unmount and fix the doc #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Taym95
changed the title
jayu
suggested changes
Apr 17, 2019
| @@ -26,10 +26,26 @@ export default class PortalConsumer extends React.Component<Props> { | |||
| } | |||
|
|
|||
| componentDidUpdate() { | |||
| if (!this.props.manager) { | |||
There was a problem hiding this comment.
Can you please extract this condition to separate class method? Do not forget to prefix the name with _ as it is a private method and place it before just before render function. Thank you for the PR!
There was a problem hiding this comment.
Or extract just error throwing. Decide what will be better for readability.
jayu
approved these changes
Apr 18, 2019
iyadthayyil
pushed a commit
to iyadthayyil/react-native-paper
that referenced
this pull request
Jun 6, 2019
…ix the modal doc example (callstack#995) * fix(portal): check if a portal manager is not null for update and unmount * docs(portal): fix Modal example
Trancever
pushed a commit
that referenced
this pull request
Jun 27, 2019
…ix the modal doc example (#995) * fix(portal): check if a portal manager is not null for update and unmount * docs(portal): fix Modal example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #991